Skip to content

pycrypto -> pycryptodome & readme update#16

Closed
grctest wants to merge 2 commits intobitshares:masterfrom
BTS-CM:master
Closed

pycrypto -> pycryptodome & readme update#16
grctest wants to merge 2 commits intobitshares:masterfrom
BTS-CM:master

Conversation

@grctest
Copy link
Copy Markdown
Contributor

@grctest grctest commented Sep 30, 2017

#15

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   45.94%   45.94%           
=======================================
  Files          38       38           
  Lines        3104     3104           
=======================================
  Hits         1426     1426           
  Misses       1678     1678
Impacted Files Coverage Δ
setup.py 100% <ø> (ø) ⬆️
bitsharesbase/memo.py 90.38% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4018815...9838a5b. Read the comment docs.

@grctest
Copy link
Copy Markdown
Contributor Author

grctest commented Sep 30, 2017

Was reading the python-bitshares docs today, and spotted the following:

Flow: pull requests need to be made against the develop branch

Want me to resubmit this PR against the development branch instead of master?

@grctest
Copy link
Copy Markdown
Contributor Author

grctest commented Oct 1, 2017

Will resubmit PR on own branch to the staging/development branch instead of directly to master (as requested in the python-bitshares documentation).

@grctest grctest closed this Oct 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants