Skip to content

Assignment Two#2

Open
blackpearl wants to merge 2 commits intomainfrom
assignment-two
Open

Assignment Two#2
blackpearl wants to merge 2 commits intomainfrom
assignment-two

Conversation

@blackpearl
Copy link
Copy Markdown
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Adding Assignment Two

What did you learn from the changes you have made?

Added Stat methods to find min, max and mean
Made use of Mean to find issues in data entry

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can eliminate the use of get_full_path function entirely by using relative path. For example: change "python/05_src/data/assignment_2_data/inflammation_01.csv" to "../../05_src/data/assignment_2_data/inflammation_01.csv"

@blackpearl
Copy link
Copy Markdown
Owner Author

@anjali-deshpande-hub Thanks for the review. I have updated the code changes

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants