This repository was archived by the owner on Aug 31, 2019. It is now read-only.
Not finished yet#23
Closed
firefaded wants to merge 2 commits intobloominstituteoftechnology:masterfrom
Closed
Conversation
Contributor
seanchen1991
left a comment
There was a problem hiding this comment.
Nice, clean code. I would also add that you should consistently write function() instead of function () with a space after the function keyword. It's an aesthetic convention and doesn't actually have a reason behind it, but keeping your code consistent is also important.
| } | ||
|
|
||
| User.prototype.comparePasswords = function (currentPassword) { | ||
| if (currentPassword === this.password) { |
Contributor
There was a problem hiding this comment.
Just wanted to point out that you can shorten this to return currentPassword === this.password;. It's not wrong to do it the way you did, just letting you know about some other ways to do it.
| constructor(options) { | ||
| this.age = options.age; | ||
| this.growOlder = function () { | ||
| return this.age; |
Contributor
There was a problem hiding this comment.
Should this be return this.age++;? I'm just going off the name of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only completed class.js and es6.js so far