Skip to content
This repository was archived by the owner on Sep 25, 2021. It is now read-only.

Fixed window property#46

Closed
siamak wants to merge 2 commits intoblueimp:masterfrom
siamak:master
Closed

Fixed window property#46
siamak wants to merge 2 commits intoblueimp:masterfrom
siamak:master

Conversation

@siamak
Copy link

@siamak siamak commented Jul 26, 2016

No description provided.

siamak added 2 commits July 26, 2016 15:44
`this` != `window`
`this` != `window`
@siamak
Copy link
Author

siamak commented Jul 26, 2016

in ES6, in this case (arrow function):

const modal = () => {
    $templates.append(tmpl('glossary', data));
}

this in case is undefined but window is working. @ShinyChang

@blueimp
Copy link
Owner

blueimp commented Jul 31, 2016

You seem to have superfluous control characters in your commit, which break the StandardJS linting tests.

Could you also provide a failing test case?
The code example you provide doesn't seem to be the source of your issue as far as I understand it.

@vinyll
Copy link

vinyll commented Nov 7, 2018

I assume this could be closed, right?

@blueimp
Copy link
Owner

blueimp commented Nov 7, 2018

@vinyll yes, thanks.

@blueimp blueimp closed this Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants