Skip to content

replace members of std::allocate which are deprecated in c++17 by the…#14

Merged
eldiener merged 1 commit intoboostorg:developfrom
DanielaE:fix/replace-deprecated-allocator-members
Dec 18, 2017
Merged

replace members of std::allocate which are deprecated in c++17 by the…#14
eldiener merged 1 commit intoboostorg:developfrom
DanielaE:fix/replace-deprecated-allocator-members

Conversation

@DanielaE
Copy link
Copy Markdown
Contributor

…irs cousins from std::allocator_traits.

@DanielaE
Copy link
Copy Markdown
Contributor Author

It looks like Travis isn't configured correctly for Linux clang.

@eldiener
Copy link
Copy Markdown
Contributor

We do not want to be checking for MSVC in particular. Instead what we want is to be using the config macro BOOST_NO_CXX11_ALLOCATOR to determine what the code should be. So please remove all the:

#if !((__cplusplus > 201700) || (defined(_MSVC_LANG) && (_MSVC_LANG > 201700)))

and substitute in its place:

#if defined(BOOST_NO_CXX11_ALLOCATOR)

then test.

@pdimov
Copy link
Copy Markdown
Member

pdimov commented Dec 16, 2017

I updated .travis.yml. g++ 7 in C++17 mode fails one test though, due to a compiler bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81311. I reported that 5 months ago but nothing seems to have happened on that front, so perhaps we need to #ifdef that out for g++ 7 in C++17 mode?

@pdimov
Copy link
Copy Markdown
Member

pdimov commented Dec 17, 2017

Yes, we do need to #ifdef it out, and we did, in eba4893. :-)

@DanielaE DanielaE force-pushed the fix/replace-deprecated-allocator-members branch 2 times, most recently from 5d96442 to 0766827 Compare December 17, 2017 06:07
@DanielaE
Copy link
Copy Markdown
Contributor Author

@eldiener

and substitute in its place:
#if defined(BOOST_NO_CXX11_ALLOCATOR)

Great - done. That was my preferred solution in the first place. But then I chose to follow Boost.Config's precedent on this particular topic ...

@DanielaE DanielaE force-pushed the fix/replace-deprecated-allocator-members branch from 0766827 to f4f8fb0 Compare December 17, 2017 06:44
@eldiener eldiener merged commit bd9c06b into boostorg:develop Dec 18, 2017
@eldiener
Copy link
Copy Markdown
Contributor

Thanks for implementing this change.

@DanielaE DanielaE deleted the fix/replace-deprecated-allocator-members branch December 19, 2017 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants