Skip to content
This repository was archived by the owner on Jan 1, 2021. It is now read-only.

fix for docker rm issue#342

Merged
SvenDowideit merged 1 commit intoboot2docker:masterfrom
SvenDowideit:possible-docker-rm-fix
May 9, 2014
Merged

fix for docker rm issue#342
SvenDowideit merged 1 commit intoboot2docker:masterfrom
SvenDowideit:possible-docker-rm-fix

Conversation

@SvenDowideit
Copy link
Copy Markdown
Contributor

@SvenDowideit SvenDowideit commented May 8, 2014

comparing the b2d/tcl init to the d2d one

http://git.tinycorelinux.net/index.cgi?url=Core-scripts.git/tree/init
vs
https://github.com/unclejack/debian2docker/blob/migrate_from_live-build/buildboot/init

and before I did anything more, I thought I'd see what the other
codepath (switch_root like d2d has...) did - so I added noembed and
moby/moby#4095 stops happening.

I have had some weird issues with tcz pkg's not being installed, but that seems to have evened out since.

@SvenDowideit SvenDowideit changed the title comparing the b2d/tcl init to the d2d one fix for docker rm issue May 8, 2014
@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented May 8, 2014

@steeve @tianon @crosbymichael

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented May 8, 2014

oh, and removes the DOCKER_RAMDISK

tianon
tianon reviewed May 8, 2014
View reviewed changes
rootfs/rootfs/usr/local/etc/init.d/docker Outdated

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tianon
Copy link
Copy Markdown
Contributor

tianon commented May 8, 2014

LGTM

@SvenDowideit
comparing the b2d/tcl init to the d2d one
c82f313 
http://git.tinycorelinux.net/index.cgi?url=Core-scripts.git/tree/init
vs
https://github.com/unclejack/debian2docker/blob/migrate_from_live-build/buildboot/init

and before I did anything more, I thought I'd see what the other
codepath did - so I added `noembed` and
moby/moby#4095 stops happening.

I have had some weird issues with tcz pkg's not being installed
@SvenDowideit SvenDowideit mentioned this pull request May 8, 2014
Merged
@steeve
Copy link
Copy Markdown
Contributor

steeve commented May 8, 2014

This is awesome.

However, according to http://distro.ibiblio.org/tinycorelinux/corebook.pdf

This is an advanced option that changes where in RAM Core is run from. By default, Core uses the tmpfs setup by the kernel; with this bootcode, Core will setup a new tmpfs file system, and use that instead.
Using this bootcode temporarily doubles the RAM use, as both copies are kept in RAM at once during boot. As an extra copy is made, it also slows the boot time. It allows GNU df to detect the
free space in /, used by some proprietary software installers."

@steeve
Copy link
Copy Markdown
Contributor

steeve commented May 8, 2014

LGTM, by the way :)

@crosbymichael
Copy link
Copy Markdown
Contributor

crosbymichael commented May 8, 2014

building now...

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented May 8, 2014

yeah @steeve , I read that too - do you have a better fix?

@SvenDowideit
Copy link
Copy Markdown
Contributor Author

SvenDowideit commented May 9, 2014

@crosbymichael how'd it go?

SvenDowideit pushed a commit that referenced this pull request May 9, 2014
Merge pull request #342 from SvenDowideit/possible-docker-rm-fix
41ad76d 
fix for docker rm issue
@SvenDowideit SvenDowideit merged commit 41ad76d into boot2docker:master May 9, 2014
This was referenced May 9, 2014
Closed
Closed
@steeve
Copy link
Copy Markdown
Contributor

steeve commented May 12, 2014

no better fix, I just wanted to put the doc here for future record. great work :)

@ailispaw ailispaw mentioned this pull request Aug 1, 2015
Closed
@SvenDowideit SvenDowideit deleted the possible-docker-rm-fix branch October 13, 2016 07:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SvenDowideit @tianon @steeve @crosbymichael