Instruct user to set DOCKER_TLS_VERIFY#269
Conversation
Signed-off-by: Aanand Prasad <[email protected]>
|
❤️ Thanks for being on top of this. |
cmds.go
Outdated
There was a problem hiding this comment.
nit: or fmt.Println(" export DOCKER_TLS_VERIFY=1") ... your call.
LGTM
There was a problem hiding this comment.
I think the idea was to parallel the one above so it's pretty. 😄
There was a problem hiding this comment.
@tianon is correct - nice to have it all line up, I reckon.
There was a problem hiding this comment.
Indeed, +1; makes it easier to spot if we ever screw it up in a case like this. 😄
|
can we perhaps replace this with a note to tell them to run mmm, though sadly, both these are bash-ish, and not fish-able. OH. and no, this is actually not enough. in adding this new Var, you also need to set the DOCKER_CERT_DIR and cmdShellinit needs to set this too - as thats the better way to set the ENV. |
|
There is also a bit of code that checks whether the environment is set: https://github.com/boot2docker/boot2docker-cli/blob/master/cmds.go#L146-L151 It'd be quite nice if it could print the commands anyway so I can copy & paste into other shells. Perhaps that logic should print the envvars anyway and then say "but it looks like you've already set them in this shell, so you're good to go!" or something. |
|
thats how the existing code works :) - but you need to add support to the shellinit cmd too |
|
Sorry, the point I was trying to make is that now needs to check for the new environment variable. |
|
Line 338 in d7b0e1b |
If any of DOCKER_HOST, DOCKER_CERT_PATH or DOCKER_TLS_VERIFY are incorrect, `boot2docker up` will inform the user, and `boot2docker shellinit` will output the correct commands to set/unset them. Signed-off-by: Aanand Prasad <[email protected]>
|
@bfirsh: fixed. All: OK, we now check all 3 environment variables and output what needs to be set/unset. |
|
LGTM |
|
LGTM - though i havn't tested |
|
moby/moby#8503 is in the 1.3.0 merge PR, moby/moby#8323 so I'm going to merge all these PRs |
Instruct user to set DOCKER_TLS_VERIFY
This is waiting on moby/moby#8503