Conversation
|
I definitely like the direction you're taking this. Having chainable queries is something I've been more and more interested in as it allows for query composition. |
|
do you think its easy to achieve or pretty complicated? I just looked into the code and got a bit confused ^^ |
|
I think it's really easy to achieve actually. I am busy with work today, so might not get a chance, but could definitely have it in by the end of the weekend. |
|
also - sorry the code is confusing. 😬 I'll try to add comments to places as I modify them in the future. I usually rely on extensive unit testing more than comments but that's not the best way to go. |
|
cool :) looking forward. guess I will provide quite a lot of pull requests in the future. well at least if I get the code :) |
|
after a few pull requests are accepted I generally give out commit access if you're interested. If you'd rather just work through pull requests I'm cool with that too - pull requests only is my workflow at work. Sometimes it's easier to just |
|
the only real rule is "all tests must pass and all new features must have tests" |
|
sounds like a plan :) |
|
This sounds good. i'll keep an eye on this thread :) |
|
this can be closed, right? |
|
ya closing |
This PR targets #57. It only contains a test. I will see if I can get this implemented on my own. But as you know the logic better than me, it might be a good idea if you could give a quick answer if that is an easily solvable issue or not :)