Open
Conversation
anjali-deshpande-hub
suggested changes
May 14, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Please make a couple of review changes:
- Replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change
r"C:\Users\sanjb\python\05_src\data\assignment_2_data\inflammation_01.csv"tor"..\..\05_src\data\assignment_2_data\inflammation_01.csv" - You don't need to define all_paths variable twice.
- The print messages can be improved for clarity and usefulness. Consider providing more context about what “All good” and “I don't know what to do” refer to.
print("All good")
else:
print("I dont know, what to do.")
anjali-deshpande-hub
approved these changes
May 19, 2025
anjali-deshpande-hub
left a comment
There was a problem hiding this comment.
Well done! All fixed. I like that you have added more test cases for Question no. 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
What did you learn from the changes you have made?
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
How were these changes tested?
A reference to a related issue in your repository (if applicable)
Checklist