Open
Conversation
Instead of trying to guess in the JavaScript what the padding difference is, we can retrieve it using getComputedStyle. The hard-coded assumption of 4px was wrong. Furthermore, it can break even more for custom CSS themes.
Member
|
Is there a bug filed on https://bugzilla.mozilla.org/ to go with this? If not, can you file one and link it here? Thanks! |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Instead of trying to guess in the JavaScript what the padding difference is, this PR suggests retrieving it using
getComputedStyle(). The hard-coded assumption of 4px was wrong. Furthermore, it can break even more for custom CSS themes.Additional info
Patch applied in Cendio's bugzilla for ThinLinc here (note that the specific bug isn't relevant, it is just an example):
https://bugzilla.cendio.com/show_bug.cgi?id=7867
Test Plan