Conversation
efantinatti
approved these changes
Dec 24, 2024
efantinatti
left a comment
There was a problem hiding this comment.
Dear Catherine Liang
Session 1:
1 - OK.
Session 2:
2 - Partial.
-- String manipulations - Q1 and Q2: Marked OK. Just a heads up, the query works but it will be limited to certain strings. If a new product comes, it won't work as expected. Consider removing CASE.
Session 3:
3 - OK.
Final:
4 - All good and you can merge your feature branch 'assignment-two' to 'main'.
Mark: 64 points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
Added code to SQL file, added text to markdown file, and uploaded 2 JPEG files for the relationship diagrams
What did you learn from the changes you have made?
Learned to use many SQL functions and think about the database structures
Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
Thought about using join in the UPDATE question but didn't get it to work properly and didn't need to use it after all
Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
UPDATE and DELETE questions were challenging
How were these changes tested?
Queried results to ensure the code worked properly
A reference to a related issue in your repository (if applicable)
N/A
Checklist