fix composer.json not being generated for private plugins#1054
Closed
fix composer.json not being generated for private plugins#1054
Conversation
Contributor
Author
|
I am stupid and forgot about this: #998 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd love to see users move the namespace definition of their private plugins inside the plugin where its actually used, not in the root composer.json like in the old days.
This is supported since CakePHP 5 / Plugin Installver v2 as you can see here
Currently when baking a plugin it doesn't generate a composer.json AND doesn't adjust the composer.json of the root app, so the generated namespace in the plugin is actually not hooked up at all.