5.next: fix behavior change introduced in phpunit 10.5.5#17510
Merged
5.next: fix behavior change introduced in phpunit 10.5.5#17510
Conversation
043046f to
362667b
Compare
dereuromark
reviewed
Dec 29, 2023
| /** | ||
| * Test scoped logging backwards compat | ||
| */ | ||
| #[WithoutErrorHandler] |
Member
There was a problem hiding this comment.
I still think those should be FQCN inside the attribute instead of use statements.
But I guess thats also the code sniffer doing this.
Contributor
Author
There was a problem hiding this comment.
Indeed the code sniffer does this
Contributor
There was a problem hiding this comment.
There wasn't an option originally, but maybe we can configure it now.
362667b to
e6babb1
Compare
Contributor
|
How is this required if that PR was reverted? |
Contributor
Author
|
I have no idea but the tests fail if we don't do this with PHPUnit >= 10.5.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: sebastianbergmann/phpunit#5619