Small fix to my patch to ticket 1079.#2
Closed
geon wants to merge 2 commits intocakephp:masterfrom
geon:master
Closed
Small fix to my patch to ticket 1079.#2geon wants to merge 2 commits intocakephp:masterfrom geon:master
geon wants to merge 2 commits intocakephp:masterfrom
geon:master
Conversation
Member
|
Thanks for the patch, #1079 is closed now, closing this pull request. I forgot to close it back when the ticket was closed. |
westernmagic
pushed a commit
to westernmagic/cakephp
that referenced
this pull request
Oct 17, 2011
…s. Updating other doc blocks for various methods in basics.php Fixes cakephp#2.
nanashiRei
added a commit
to yas-online/cakephp
that referenced
this pull request
Jan 15, 2013
juanibanes
pushed a commit
to Fragment/CakePHP
that referenced
this pull request
Feb 7, 2014
juanibanes
pushed a commit
to Fragment/CakePHP
that referenced
this pull request
Feb 7, 2014
juanibanes
pushed a commit
to Fragment/CakePHP
that referenced
this pull request
Feb 7, 2014
markstory
pushed a commit
that referenced
this pull request
Mar 12, 2014
Allow sub-directories for Fixture folder
Closed
2 tasks
3 tasks
markstory
pushed a commit
that referenced
this pull request
Mar 28, 2017
Update schema reflection for postgres.
3 tasks
inoas
added a commit
to inoas/cakephp
that referenced
this pull request
Oct 16, 2017
inoas
added a commit
to inoas/cakephp
that referenced
this pull request
Oct 17, 2017
3 tasks
markstory
pushed a commit
that referenced
this pull request
Apr 24, 2018
1 task
3 tasks
1 task
3 tasks
This was referenced May 21, 2021
ADmad
pushed a commit
that referenced
this pull request
Feb 24, 2026
) * WIP: Add proper generic type annotations to fix PHPStan missingType.generics This is a work-in-progress to properly specify generic types instead of ignoring the missingType.generics errors in PHPStan. Changes include: - Add @template annotations to Helper, View subclasses, Cache classes - Add proper generic type parameters to method signatures - Fix Collection, ORM, Event system generic types Progress: ~210 of 405 errors fixed (52%) Remaining work needed for complete fix. * Additional fixes from parallel agents * Fix remaining missingType.generics errors Complete the fix for generic type annotations by: - Add generic types to Association.php methods (attachTo, find, etc.) - Add @phpstan-ignore for self-referential generics in EventDispatcherTrait - Fixes all remaining missingType.generics errors Remaining 69 errors are different types (return.type, argument.type, generics.interfaceConflict) not related to the original missingType.generics issue. * Fix PHPStan errors to make CI green - Add @phpstan-ignore comments for Collection return type mismatches - Add path-specific ignores for generics.interfaceConflict in TreeIterator/TreePrinter - Add path-specific ignores for argument.type covariance issues in Cache/ORM - Use consistent SelectQuery generic types in Association.php * Move argument.type ignores to inline comments - Cache.php: inline ignore for NullEngine fallback - TableRegistry.php: inline ignore for TableLocator - bootstrap.php: inline ignore for TableLocator generics.interfaceConflict must remain in config (PHPStan limitation for class-level interface conflicts) * Improve inline ignore comments wording * Fix phpcs violations - Remove unused import EntityInterface from EagerLoader - Remove @inheritdoc when combined with @param/@return (coding standard violation) - Add proper type hints and @param annotations * Merge pull request #1 from rochamarcelo/suggestions-generic-usage-on-view Suggestions for generic usage on view * Cleanup. * use static instead of self used generic template on command (#2) * use static instead of self used generic template * use static instead of self used generic template * Fix PHPStan errors in ORM association cascade delete methods Add @phpstan-ignore for argument.type errors where cascade callback code iterates over query results. The SelectQuery template includes array type for non-hydrated results, but cascade callbacks always use hydration, so entities are guaranteed. --------- Co-authored-by: Marcelo Rocha <[email protected]>
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.