Skip to content

Add unix socket support to Redis cache engine#3438

Closed
DIDoS wants to merge 2 commits intocakephp:masterfrom
DIDoS:master
Closed

Add unix socket support to Redis cache engine#3438
DIDoS wants to merge 2 commits intocakephp:masterfrom
DIDoS:master

Conversation

@DIDoS
Copy link
Copy Markdown
Contributor

@DIDoS DIDoS commented May 5, 2014

  • adds support for unix sockets
    example:
    'unix_socket' => '/home/user/.redis/sock'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be if (

@lorenzo
Copy link
Copy Markdown
Member

lorenzo commented May 7, 2014

Is it ok to merge this feature directly to master?

@markstory
Copy link
Copy Markdown
Member

Either that, or we roll it into 2.5.0.

@jippi
Copy link
Copy Markdown
Contributor

jippi commented May 8, 2014

why not just call the param socket - sockets only really exist on unix anyway, and thats the usual term used in linux land :)

@ADmad
Copy link
Copy Markdown
Member

ADmad commented May 8, 2014

@jippi Fair point, but in db config also the key name unix_socket is used so using the same would be better for consistency.

@markstory markstory added this to the 2.5.0 milestone May 8, 2014
@DIDoS
Copy link
Copy Markdown
Contributor Author

DIDoS commented May 8, 2014

@ADmad exactly, I tried to follow the mysql dbo driver

@jippi
Copy link
Copy Markdown
Contributor

jippi commented May 9, 2014

OK, np, think it should be renamed when merged into cake 3

markstory pushed a commit that referenced this pull request May 12, 2014
@markstory
Copy link
Copy Markdown
Member

Merged into 2.5 in cd445f2

@markstory markstory closed this May 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants