Remove strict typing for PHP 5.6 compatibility#51
Merged
dereuromark merged 1 commit intomasterfrom Oct 29, 2020
Merged
Conversation
dereuromark
approved these changes
Oct 28, 2020
Contributor
|
@nojimage Can you test this with 5.6 and composer 2? |
Member
|
Wouldn't it make sense to re-add PHP 5.6-7.1 to Travis CI, then? |
Member
Author
|
Phpunit 8+ requires So running the testsuite on all supported PHP versions would either require modifying the test case file after installation or having separate files and running required one based on PHP one. I personally am not interested in spending time on that. |
Contributor
|
This is just a quick fix to have a version that's compatible so we can move on. |
Contributor
|
It works fine on PHP 5.6 with composer 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #50.