Skip to content

Tricia #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
campbe13 merged 2 commits into from
Jun 5, 2020
Merged

Tricia #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6121f4b
update readme
campbe13 Jun 5, 2020
c332515
test w/o script lint.sh
campbe13 Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

# to campbe13.github.io

# linter not working properly so test without the script
language: node_js
node_js:
- 13
Expand All @@ -16,5 +17,5 @@ deploy:
keep_history: true
on:
branch: master
script: ./lint.sh
#script: ./lint.sh

3 changes: 0 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ For use with students I would set it up for merges to master instead of each pus
3. maybe replace this (README.md) page with student info or an index.html ? will it supercede ?
4. limit what is copied to github pages do I need node_modules ?? test in .gitignore
2. fix the linter I am using, it's too strict
3. figure out the build vs pull deployment trigger
1. Build pushed branches off & build pushed pull requests on; pull request deploys master (why useful?)
2. Build pushed branches off & build pushed pull requests on; tbd
2. try github actions instead
3. deploy to korra instead
4. try with gitlab ci
Expand Down