Celluloid::Method should respond to Method methods#300
Merged
halorgium merged 1 commit intocelluloid:masterfrom Oct 12, 2013
LTe:support-for-other-methods
Merged
Celluloid::Method should respond to Method methods#300halorgium merged 1 commit intocelluloid:masterfrom LTe:support-for-other-methods
halorgium merged 1 commit intocelluloid:masterfrom
LTe:support-for-other-methods
Conversation
Contributor
There was a problem hiding this comment.
Turning the method into a Proc is a little bit scary as the calling of the Proc should probably occur inside the actor.
Contributor
|
@LTe I don't think we can accept this as it currently stands. |
When you use Celluloid Actor you will use proxy class Celluloid::Method to execute code through actor in sync or async way. Some libraries expects that Method (Celluloid::Method) object will be respond to methods from standard library Method.
Contributor
Author
|
@halorgium updated. I implemented only |
Contributor
|
@LTe thanks so much! I'll merge once the tests are green. |
Contributor
Author
|
@halorgium this is strange because in this build |
Contributor
|
@LTe there are 1 or 2 tests which still can cause deadlocks. |
halorgium
added a commit
that referenced
this pull request
Oct 12, 2013
Celluloid::Method should respond to Method methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you use Celluloid Actor you will use proxy class Celluloid::Method
to execute code through actor in sync or async way. Some libraries expects
that Method (Celluloid::Method) object will be respond to methods from
standard library Method.
This bug is related to: psyho/bogus#24