Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Prepare for 0.4.0 release#604

Merged
c24t merged 5 commits intocensus-instrumentation:v0.4.xfrom
c24t:v0.4.0
Apr 9, 2019
Merged

Prepare for 0.4.0 release#604
c24t merged 5 commits intocensus-instrumentation:v0.4.xfrom
c24t:v0.4.0

Conversation

@c24t
Copy link
Copy Markdown
Member

@c24t c24t commented Apr 5, 2019

Update the version numbers, setup files, and changelogs for the 0.4.0 core library release and multiple ext package releases.

Ext packages with insignificant changes, micro version updates:

  • opencensus-ext-dbapi
  • opencensus-ext-google-cloud-clientlibs
  • opencensus-ext-grpc
  • opencensus-ext-httplib
  • opencensus-ext-mysql
  • opencensus-ext-postgresql
  • opencensus-ext-pymongo
  • opencensus-ext-pymysql
  • opencensus-ext-requests
  • opencensus-ext-sqlalchemy
  • opencensus-ext-threading

Ext packages affected by package changes in the core library, minor version updates:

  • opencensus-ext-django
  • opencensus-ext-flask
  • opencensus-ext-jaeger
  • opencensus-ext-pyramid
  • opencensus-ext-prometheus
  • opencensus-ext-zipkin

Ext packages with significant changes, also minor version updates:

  • opencensus-ext-ocagent
  • opencensus-ext-stackdriver

Fixes #597.

# limitations under the License.

__version__ = '0.2.dev0'
__version__ = '0.1.0'
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reyang do you want to keep releasing this package?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you (depending on which way is easier for you). We don't have dependency from opencensus and there is no actual functionality, no need to release it.

Once we heard back from @bogdandrutu, we can decide whether to put the correlation context work in this package, or remove it (and do the implementation in opencensus core lib).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I won't touch it in this branch and it'll be released again as the same version.

'opencensus >= 0.4.dev0, < 1.0.0',
'opencensus-ext-grpc >= 0.2.dev0, < 1.0.0',
'opencensus-ext-requests >= 0.2.dev0, < 1.0.0',
'opencensus >= 0.3.0, < 1.0.0',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ext packages that don't depend on changes in the core library I didn't change the required opencensus version. This could get confusing quickly since this requirement will be 0.5.dev0 on master to allow us to keep making breaking changes on the dev version.

We may want to keep these version numbers in sync across all the ext packages in the interest of our sanity, at the cost of backwards compatibility.

@c24t
Copy link
Copy Markdown
Member Author

c24t commented Apr 5, 2019

CI will fail for PRs like this that update the core library version and ext requirements to depend on that version in the same change. We may fix this as part of #544.

@reyang
Copy link
Copy Markdown
Contributor

reyang commented Apr 5, 2019

CI will fail for PRs like this that update the core library version and ext requirements to depend on that version in the same change. We may fix this as part of #544.

I think this is because we haven't updated opencensus/common/version/__init__.py?

@c24t
Copy link
Copy Markdown
Member Author

c24t commented Apr 5, 2019

That'd do it, updated in b0fb1dd.

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 5, 2019
@c24t
Copy link
Copy Markdown
Member Author

c24t commented Apr 5, 2019

Rebased to include 1689f98 and 294bc2c.

@c24t c24t added cla: yes and removed cla: no labels Apr 5, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot removed the cla: yes label Apr 9, 2019
@c24t c24t added cla: yes and removed cla: no labels Apr 9, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 9, 2019
@c24t c24t added cla: yes and removed cla: no labels Apr 9, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@c24t c24t merged commit 11d1527 into census-instrumentation:v0.4.x Apr 9, 2019
@c24t c24t deleted the v0.4.0 branch April 9, 2019 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants