Improve code quality: simplify is_leap_year and refactor ISO 8601 parsing#19
Merged
chetmancini merged 1 commit intomasterfrom Jan 25, 2026
Merged
Improve code quality: simplify is_leap_year and refactor ISO 8601 parsing#19chetmancini merged 1 commit intomasterfrom
chetmancini merged 1 commit intomasterfrom
Conversation
…egex, and fix exception handling - Replace manual leap year calculation with calendar.isleap() - Move ISO 8601 regex to module-level compiled pattern with verbose mode for readability - Fix overly broad Exception catches in timezone functions to catch ZoneInfoNotFoundError - Add ZoneInfoNotFoundError to imports Co-Authored-By: Claude Haiku 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
is_leap_year()to use the stdlibcalendar.isleap()functionparse_iso8601()regex to module-level compiled pattern with verbose mode for improved readabilityExceptioncatches in timezone functions (now_in_timezone,convert_timezone,get_timezone_offset) to specifically catchZoneInfoNotFoundErrorZoneInfoNotFoundErrorto importsTest Plan
🤖 Generated with Claude Code