Skip to content

Fix ISO8601 validation and start defaults#26

Merged
chetmancini merged 1 commit intomasterfrom
chetmancini/pr-dateutils-fixes
Feb 6, 2026
Merged

Fix ISO8601 validation and start defaults#26
chetmancini merged 1 commit intomasterfrom
chetmancini/pr-dateutils-fixes

Conversation

@chetmancini
Copy link
Copy Markdown
Owner

@chetmancini chetmancini commented Feb 6, 2026

Summary

  • Ensure parse_iso8601 returns None for invalid dates, times, and offsets.
  • Reject invalid timezone components in ISO8601 offsets (for example +02:99).
  • Use explicit None checks in generate_quarters and generate_years so falsy explicit values are preserved.
  • Add regression tests for invalid ISO8601 values, start_quarter=0, and start_year=0.

Validation

  • uv run pytest -q
  • uv run ruff check .
  • uv run ty check

@claude
Copy link
Copy Markdown

claude Bot commented Feb 6, 2026


Code review

No issues found. Checked for bugs and CLAUDE.md compliance.


@chetmancini chetmancini merged commit 599a5eb into master Feb 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant