Fix date_range limit to account for leap days#28
Merged
chetmancini merged 1 commit intomasterfrom Feb 6, 2026
Merged
Conversation
The 10-year limit used 3650 days (10 * 365), but a valid 10-calendar-year range with leap days can span up to 3653 days. For example, 2020-01-01 to 2029-12-31 contains 3 leap years (2020, 2024, 2028) and should be accepted but was rejected. Changed the threshold from 10 * DAYS_IN_YEAR to 10 * DAYS_IN_YEAR + 3 to accommodate up to 3 leap days that can occur in any 10-year span. Co-Authored-By: Claude Haiku 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the 10-year limit in
date_range()to correctly account for leap days. The previous limit of 3650 days (10 * 365) incorrectly rejected valid 10-calendar-year ranges containing leap days.Changes
10 * DAYS_IN_YEARto10 * DAYS_IN_YEAR + 3(3653 days)Testing
All 126 tests pass, including verification that the reported example case is now accepted.
🤖 Generated with Claude Code