Merged
Conversation
…coverage - Fix incorrect date comments in test_dateutils.py (timestamps were 2024-03-28, not 2024-03-27) - Replace int(x / y) with x // y in pretty_date for Pythonic floor division (10 occurrences) - Remove unreachable branch in parse_iso8601 (regex guarantees ms_part and tz_part are None when time_part is None) - Remove redundant None guard in add_business_days (holidays=None already returns early) - Remove redundant num_days == 0 check in _add_business_days_no_holidays (caller already handles it) - Add test coverage for add_business_days with backward direction from weekend starts (no-holidays fast path) Co-Authored-By: Claude Haiku 4.5 <[email protected]>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed incorrect test comments, simplified code patterns, removed redundant checks, and improved test coverage.
Test plan
🤖 Generated with Claude Code