Fix coronating ruler inviting themselves#261
Merged
Whizzer merged 1 commit intock2plus:mainfrom Feb 21, 2023
Merged
Conversation
* Adds an additional check to `send_coronation_invitations_effect` that excludes the coronating ruler from potential rulers to invite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excludes the coronating ruler from potential rulers to invite.
So far tested by playing as Petty King of York in 867, gave myself the Titular Kingdom of York through console commands, ended the war by imprisoning the Petty King of Northumbria through console commands, and picked the Royal Coronation intrigue decision. No letter event (Plus.1201) was sent to myself when compared to previous plays.
Needs further testing by me with imperial coronation and review if there are any problems.Seems to work with Imperial Coronation work no other problems.