Merged
Conversation
Moved to religion feature. Will need further testing to determine whether this is even needed. Vanilla and CleanSlate lord spiritual events do not use this flag and are otherwise identical.
Removed the greeting event. Renamed namespace for startup events to startPlus for brevity. Moved several functions to scripted_effects
k_papacy_chalcedonian no longer had a function. Removed it.
Further revision will be needed to fix the Chalcedonian College of Cardinals not being fully functional (missing "preferatus" and "expected next cardinal"). Suspect issue with succession voting rules.
Simplified some logic, Added in an effect for the actual schism. Also slightly tweaked the Chalcedonian Cardinals to try to get them to work correctly (they still don't fully due to a vanilla bug)
Moved some larger effects to scripted effects, combined checksum and ironman warnings into one event
Event has been disabled since July 2020. Annotation expresses confusion as to its purpose
Event gave -50 piety to muslim characters yearly when at peace. Was marked as `is_triggered_only` and never called in Plus, CleanSlate, or Vanilla
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.