Skip to content

Fixed ability to convert tribal holdings to cities #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schwarherz merged 2 commits into from
Jun 15, 2024
Merged

Fixed ability to convert tribal holdings to cities #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07f1e5e
Fixed ability to convert tribal holdings to cities
schwarherz Jun 15, 2024
c89fa5e
Fix corrupted text
schwarherz Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions CK2Plus/decisions/CK2Plus_realm_decisions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,7 @@ decisions = {
holding_type = city
AND = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}
}
}
Expand All @@ -780,7 +780,7 @@ decisions = {

any_province_holding = {
holding_type = tribal
NOT = { has_building = tb_basic_keep_5 }
NOT = { has_building = tb_town_hall_5 }
}
}

Expand Down Expand Up @@ -873,7 +873,7 @@ decisions = {

any_province_holding = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}
}

Expand All @@ -892,7 +892,7 @@ decisions = {
any_province_holding = {
limit = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}
set_title_flag = refill_levy
convert_to = city
Expand All @@ -919,7 +919,7 @@ decisions = {

any_province_holding = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}
}

Expand All @@ -938,7 +938,7 @@ decisions = {
any_province_holding = {
limit = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}

set_title_flag = refill_levy
Expand Down Expand Up @@ -1033,7 +1033,7 @@ decisions = {
any_demesne_title = {
tier = baron
holding_type = tribal
NOT = { has_building = tb_basic_keep_5 }
NOT = { has_building = tb_town_hall_5 }
location = { NOT = { culture = ROOT } }
}

Expand Down Expand Up @@ -1181,7 +1181,7 @@ decisions = {
holding_type = city
AND = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}
}
}
Expand All @@ -1195,7 +1195,7 @@ decisions = {

any_province_holding = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}
}

Expand All @@ -1214,7 +1214,7 @@ decisions = {
any_province_holding = {
limit = {
holding_type = tribal
has_building = tb_basic_keep_5
has_building = tb_town_hall_5
}

set_title_flag = refill_levy
Expand Down Expand Up @@ -1295,7 +1295,7 @@ decisions = {
any_demesne_title = {
tier = baron
holding_type = tribal
NOT = { has_building = tb_basic_keep_5 }
NOT = { has_building = tb_town_hall_5 }
location = { NOT = { culture = ROOT } }
}

Expand Down
33 changes: 11 additions & 22 deletions CK2Plus/decisions/settlement_decisions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,28 +27,22 @@ settlement_decisions = {
}

potential = {
# Filter doesn't seem to be enough
holder = FROM
holder = FROM # filter doesn't seem to be enough
holding_type = tribal
}

allow = {
has_building = tb_basic_keep_5

location = {
show_scope_change = no
location = { religion = FROM }

religion = FROM
}
has_building = tb_basic_keep_5
}

effect = {
convert_to = castle
set_title_flag = refill_levy
set_title_flag = refill_levy # I don't think this does anything anymore. What did it do? It's never called and only used in Plus
refill_holding_levy = yes

hidden_effect = {
refill_holding_levy = yes

location = { # Clear Tribal Great Pillars
clr_province_flag = flag_great_pillar_norse
clr_province_flag = flag_great_pillar_tengri
Expand Down Expand Up @@ -95,22 +89,17 @@ settlement_decisions = {
}

allow = {
has_building = tb_basic_keep_5

location = {
show_scope_change = no
location = { religion = FROM }

religion = FROM
}
has_building = tb_town_hall_5
}

effect = {
convert_to = city
set_title_flag = refill_levy
refill_holding_levy = yes

hidden_effect = {
refill_holding_levy = yes

location = { # Clear Tribal Great Pillars
clr_province_flag = flag_great_pillar_norse
clr_province_flag = flag_great_pillar_tengri
Expand Down Expand Up @@ -1154,7 +1143,7 @@ settlement_decisions = {
if = {
limit = {
FROM = {
dynasty = 708 #Ýrpád
dynasty = 708 # �rp�d
has_landed_title = k_hungary
}
}
Expand Down Expand Up @@ -1327,7 +1316,7 @@ settlement_decisions = {
FROM = {
trigger_if = {
limit = {
NOT = { dynasty = 708 } # Árpád
NOT = { dynasty = 708 } # �rp�d
}

num_of_subrealm_castles >= 10
Expand Down Expand Up @@ -1358,7 +1347,7 @@ settlement_decisions = {

mult_modifier = {
factor = 100
FROM = { dynasty = 708 } # Ýrpád
FROM = { dynasty = 708 } # �rp�d
Copy link
Copy Markdown
Contributor Author

@schwarherz schwarherz Jun 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only displays wrong because GitHub uses UTF-8 encoding when displaying the file. I checked the file itself and it is correct.

}
}
}
Expand Down