Merged
Conversation
Didn’t realize that child_process functions don’t return promises
Run some tests in the future and ensure gzip is worth it for smaller responses
This makes it easier to run inside docker, since we are no longer attempting to run docker inside docker
This is sad, because now we are now dependent on mongorestore for tests to function. Using the node driver to load mongoexport data was just too troublesome however (which had no dependencies beyond what npm installed)
Test usually fails since mongo text index hasn’t finished building. Should add a `/ready` endpoint and then poll that until the app is ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #28, closes #38