feat(clerk-js): Change the default behaviour of afterSignOutUrl, afterSignIn and afterSignUp by octoper · Pull Request #2020 · clerk/javascript

octoper · 2023-11-02T21:08:01Z

Description

This PR changes the default behaviour of the following

Change the default behaviour of after afterSignOutUrl prop in <UserButton /> to be redirected to / instead of the Account Portal defined url.
Change the default behaviour of after afterSignIn and afterSignUp props to be redirected to / instead of the Account Portal defined url.
Use the default options for the Clerk singleton as right now they get overwritten from undefined values.
Added a utility function to @clerk/shared package, that receives an object and returns it back without the properties undefined value.

Checklist

npm test runs as expected.
npm run build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

Packages affected

changeset-bot · 2023-11-02T21:08:05Z

🦋 Changeset detected

Latest commit: 59ab8ae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@clerk/clerk-js	Major
@clerk/shared	Patch
@clerk/chrome-extension	Patch
@clerk/clerk-expo	Patch
@clerk/backend	Patch
@clerk/fastify	Patch
@clerk/nextjs	Patch
@clerk/clerk-react	Patch
@clerk/remix	Patch
@clerk/clerk-sdk-node	Patch
gatsby-plugin-clerk	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

anagstef · 2023-11-03T08:07:31Z

packages/clerk-js/src/core/clerk.ts

+  afterSignInUrl: '/',
+  afterSignUpUrl: '/',


There are more places in our codebase where we use displayConfig.afterSignInUrl and displayConfig.afterSignUpUrl. Are those also considered?

After the changes I made the default values will be directly taken from the defaultOptions so the displayConfig.afterSignInUrl or displayConfig.afterSignUpUrl are never used.

nikosdouvlis

@octoper You will need to apply the changes to the ui-retheme dir. I will share more details within the day

.changeset/spotty-boxes-do.md

packages/clerk-js/src/core/clerk.redirects.test.ts

nikosdouvlis · 2023-11-16T07:38:41Z

packages/clerk-js/src/core/clerk.ts

+  afterSignInUrl: '/',
+  afterSignUpUrl: '/',


I need to take another look, but my instinct tells me that this is not the direction we want to go as this will cause these to have actual values so, by default, the URLs will include the query params.

What we want to do instead, is to change the behavior of Clerk IF these are undefined

Made the changes to only fallback to / and the values will not be included to the query params.

packages/clerk-js/src/utils/pagesToOffset.ts

packages/clerk-js/src/core/clerk.redirects.test.ts

…ding Clerk client

…of empty string

… as fallbacks

octoper requested a review from a team as a code owner November 2, 2023 21:08

clerk-cookie added clerk-js playground labels Nov 2, 2023

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch from 2e81ce1 to 91fe24d Compare November 2, 2023 21:08

octoper changed the title ~~feat(clerk-js): Change the default behavior of afterSignOutUrl, afterSignIn and afterSignUp~~ feat(clerk-js): Change the default behaviour of afterSignOutUrl, afterSignIn and afterSignUp Nov 2, 2023

anagstef reviewed Nov 3, 2023

View reviewed changes

dimkl force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch from 7aecc46 to eae95f2 Compare November 6, 2023 11:29

dimkl assigned octoper Nov 6, 2023

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch 2 times, most recently from 35db2db to 0ffd8bf Compare November 7, 2023 11:02

clerk-cookie added nextjs remix labels Nov 7, 2023

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch 2 times, most recently from 42e46a1 to 320b770 Compare November 8, 2023 11:05

nikosdouvlis requested changes Nov 9, 2023

View reviewed changes

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch 2 times, most recently from 74cc3f8 to 9997c00 Compare November 10, 2023 10:02

octoper requested review from anagstef and nikosdouvlis November 13, 2023 16:26

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch 3 times, most recently from 5c30f34 to 15b3a32 Compare November 15, 2023 08:47

anagstef reviewed Nov 15, 2023

View reviewed changes

.changeset/spotty-boxes-do.md Outdated Show resolved Hide resolved

packages/clerk-js/src/core/clerk.redirects.test.ts Outdated Show resolved Hide resolved

anagstef approved these changes Nov 15, 2023

View reviewed changes

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch from af58073 to 021108b Compare November 15, 2023 14:46

nikosdouvlis requested changes Nov 16, 2023

View reviewed changes

dimkl reviewed Nov 16, 2023

View reviewed changes

packages/clerk-js/src/utils/pagesToOffset.ts Show resolved Hide resolved

packages/clerk-js/src/core/clerk.redirects.test.ts Outdated Show resolved Hide resolved

clerk-cookie added retheme and removed nextjs labels Nov 16, 2023

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch from bf04a09 to 2c10bf3 Compare December 4, 2023 15:34

nikosdouvlis approved these changes Dec 6, 2023

View reviewed changes

octoper added 22 commits December 6, 2023 11:10

feat(clerk-js): Change the default path of afterSignOutUrl

5801a06

feat(clerk-js,shared): Use default options if nothing passed when loa…

ac94a63

…ding Clerk client

chore(repo): Update NextJS playground

bb62c3c

chore(clerk-js): Fix typo

3255cf4

chore(repo): Added Changeset

b7775b3

chore(shared): Fixed types for getNonUndefinedValues and added tests

0d4204e

fix(remix): Utility function getEnvVariable return undefined instead …

6e4ef19

…of empty string

fix(clerk-js): Give empty object when options are undefined

c856132

test(shared): Fixed test for getNonUndefinedValues utility function

936fdf2

fix(clerk-js): Apply changes to ui.retheme

060401b

fix(clerk-js): Add missing import

016da40

fix(clerk-js): Add missing import

6c23963

test(clerk-js): Update Clerk redirect tests

2260eb9

chore(repo): Update Changeset

c58c6f0

chore(remix): Update return type comment

e34efdd

fix(clerk-js): Use the defaults for afterSignInUrl and afterSignUpUrl…

09ae7be

… as fallbacks

chore(remix): Update return type of getEnvVariable utility function

58aba6a

test(clerk-js): Update test for SignInStart component

4fb3201

test(clerk-js): Update test for SignInStart component in ui.retheme

b47a5c0

feat(clerk-js): Removed display config values

e8ebc75

chore(repo): Apply Prettier formating

74b0d29

chore(shared): Remove unused import from tests

59ab8ae

octoper force-pushed the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch from 2c10bf3 to 59ab8ae Compare December 6, 2023 09:10

octoper added this pull request to the merge queue Dec 6, 2023

Merged via the queue into main with commit d30ea1f Dec 6, 2023

octoper deleted the vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton branch December 6, 2023 09:53

clerk-cookie mentioned this pull request Dec 5, 2023

Version Packages (alpha-v5) #2238

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(clerk-js): Change the default behaviour of afterSignOutUrl, afterSignIn and afterSignUp#2020

feat(clerk-js): Change the default behaviour of afterSignOutUrl, afterSignIn and afterSignUp#2020
octoper merged 22 commits intomainfrom
vaggelis/sdk-831-change-the-default-behavior-of-aftersignouturl-of-userbutton

octoper commented Nov 2, 2023 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 2, 2023 •

edited

Loading

Uh oh!

anagstef Nov 3, 2023

Uh oh!

octoper Nov 7, 2023 •

edited

Loading

Uh oh!

nikosdouvlis left a comment

Uh oh!

Uh oh!

Uh oh!

nikosdouvlis Nov 16, 2023

Uh oh!

octoper Nov 16, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

octoper commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Packages affected

Uh oh!

changeset-bot bot commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

anagstef Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

octoper Nov 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikosdouvlis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nikosdouvlis Nov 16, 2023

Choose a reason for hiding this comment

Uh oh!

octoper Nov 16, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

octoper commented Nov 2, 2023 •

edited

Loading

changeset-bot bot commented Nov 2, 2023 •

edited

Loading

octoper Nov 7, 2023 •

edited

Loading