feat(localizations): Allow the usage of subpath imports#2046
feat(localizations): Allow the usage of subpath imports#2046MonsterDeveloper wants to merge 5 commits intoclerk:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 93595d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hey Andrew, thanks for the PR! Seems like a good change, however we'll need to test this a bit more since we have made the experience in the past (with the revamped https://github.com/clerk/clerk-expo-starter should be a good starting ground to test. I won't get to testing this today and will be on vacation soon, I'll make sure to hand this PR off to a colleague then. |
|
Thanks @LekoArts, looking forward to getting this merged. Let me know if I can help you with the testing. |
|
Hey! Any ETA on this one?
|
The addition of `.gitignore` and `subpaths.mjs` is used to support Expo framework. This fix is also used in `@clerk/shared` package. original PR: #2046 Co-authored-by: MonsterDeveloper
The addition of `.gitignore` and `subpaths.mjs` is used to support Expo framework. This fix is also used in `@clerk/shared` package. original PR: #2046 Co-authored-by: Andrew <[email protected]>
|
Hello @MonsterDeveloper 👋 , |
The addition of `.gitignore` and `subpaths.mjs` is used to support Expo framework. This fix is also used in `@clerk/shared` package. original PR: #2046 Co-authored-by: Andrew <[email protected]>
|
Thanks @dimkl ! Looking forward to getting this new PR merged. |
* feat(localizations): Allow usage of subpath exports The addition of `.gitignore` and `subpaths.mjs` is used to support Expo framework. This fix is also used in `@clerk/shared` package. original PR: #2046 Co-authored-by: Andrew <[email protected]> * update changeset --------- Co-authored-by: Andrew <[email protected]> Co-authored-by: Lennart <[email protected]>
Description
The
localizationspackage now allows for subpath exports.This should help with tree-shaking by helping the bundler to include only specific localization.
This is a non-breaking change-previous imports from
@clerk/localizationsare still working as expected.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore