feat(chrome-extension,shared): Expand WebSSO capabilities. [SDK-836]#2246
Closed
feat(chrome-extension,shared): Expand WebSSO capabilities. [SDK-836]#2246
Conversation
🦋 Changeset detectedLatest commit: 7d73465 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
5a4ae89 to
9e5ebbd
Compare
Member
Author
|
Swapping back to draft as I submitted an alternate approach to this in #2249. Open to discussion. |
SokratisVidros
suggested changes
Dec 5, 2023
| @@ -0,0 +1,19 @@ | |||
| export function validateManifest(manifest: chrome.runtime.Manifest): void { | |||
| // TODO: Listen to client cookie changes and sync updates | ||
| // https://developer.chrome.com/docs/extensions/reference/cookies/#event-onChanged | ||
| // Will throw if manifest is invalid | ||
| validateManifest(chrome.runtime.getManifest()); |
| requestInit.url?.searchParams.append('_is_native', '1'); | ||
| const clientCookie = await (key.instanceType === 'production' | ||
| ? getClientCookie(key.frontendApi, CLIENT_JWT_KEY) | ||
| : getClientCookie(syncSessionHost, DEV_BROWSER_JWT_MARKER) |
Contributor
There was a problem hiding this comment.
It seems that we can get the syncSessionHost from manifest.json and remove the need for the extra prop.
9e5ebbd to
3259834
Compare
3259834 to
e935e92
Compare
42667fe to
e935e92
Compare
Member
Author
|
Closing in favor of #2277, which is basically this with a few additions. The new PR was created due to some rebase oddities with the Chrome playground PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the ability to sync development instances of a Chrome Extension with a host app using URL-based session syncing.
More information: https://www.notion.so/clerkdev/Chrome-extensions-and-URL-based-session-syncing-135e04959e664b26a2076fc031174460
Fixes SDK-836
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore