fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
fix(clerk-react): Fix build process not catching type errors [SDK-1065]#2312
Conversation
🦋 Changeset detectedLatest commit: 0cdc277 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
10f6151 to
6d2d4a9
Compare
|
@tmilewski We should probably do this for the rest of the packages:
|
|
1d5aa4e to
6767273
Compare
There was a problem hiding this comment.
🔧 I think that those keys are dropped in Retheme project as part of #2290
Is there an error somewhere that indicated to make these changes?
There was a problem hiding this comment.
Yes, it was giving me errors when running tsc. If they're supposed to be dropped then I can look into it more.
| permission: unknown; | ||
| role: unknown; | ||
| } | ||
|
|
There was a problem hiding this comment.
It is, it was the only way I could get this to build and test, as it wasn't available at the time. My plan was to rebase everything and weed it out once it came time.
There was a problem hiding this comment.
🔧 Those keys are only added in Retheme project and they are supposed to exist in packages/types/src/localization.retheme.ts and not here. We should remove them from this file.
| sourcemap: true, | ||
| dts: true, | ||
| splitting: false, | ||
| onSuccess: 'tsc', |
There was a problem hiding this comment.
Why not set dts: false then? Then we'd do double the work
6767273 to
0cdc277
Compare
nikosdouvlis
left a comment
There was a problem hiding this comment.
Folks, are we sure this is the case? Are there any open issues I can read for more context?
I tested tsup locally with a few isolated scenarios and the build fails as expected.
In any case, let's wait before we consider merging this as we are making too many build-related changes across the codebase for v5.
|
@nikosdouvlis I was able to get it to consistently succeed/fail in various scenarios. That said, I agree that we should hold, and I'm going to close for the time being. |
Description
tsupdoesn't reliably handle type-checking, thus we must continue to rely ontsc.SDK-1065
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore