chore(clerk-js): Update zxcvbn dependency#2326
Merged
Conversation
🦋 Changeset detectedLatest commit: 020bdf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
approved these changes
Dec 12, 2023
Contributor
|
@LekoArts Would we backport this change? |
LekoArts
added a commit
that referenced
this pull request
Dec 13, 2023
* chore(clerk-js): Update zxcvbn dependency * chore(repo): Add changesets (cherry picked from commit 69ce3e1)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
* chore(clerk-js): Update zxcvbn dependency * chore(repo): Add changesets (cherry picked from commit 69ce3e1) Co-authored-by: Lennart <[email protected]>
octoper
pushed a commit
that referenced
this pull request
Dec 13, 2023
* chore(clerk-js): Update zxcvbn dependency * chore(repo): Add changesets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We received a complaint that our version has a security issue, so here goes the update.
@zxcvbn-ts/corefrom2.2.1to3.0.4. Update@zxcvbn-ts/language-commonfrom3.0.2to3.0.4.ZxcvbnResultinterface to use currentfeedback.warningtype as used in the upstream@zxcvbn-ts/corelibrary.Relevant changelogs:
We were already using the right imports / used the latest major of the language package, so that's why the changes are so small.
Only needed to adjust our internal types to: https://github.com/zxcvbn-ts/zxcvbn/blob/2c5882d1cbfbe624adbb5a31919000c98eea98c1/packages/libraries/main/src/types.ts#L152-L155
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore