-
Notifications
You must be signed in to change notification settings - Fork 8.3k
[gh run watch] Support --compact flag
#10629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
22e092a
37690a7
4276a7f
b81b172
1754ead
e3cabe2
221d537
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,6 +57,15 @@ func TestNewCmdWatch(t *testing.T) { | |
| ExitStatus: true, | ||
| }, | ||
| }, | ||
| { | ||
| name: "compact status", | ||
| cli: "1234 --compact", | ||
| wants: WatchOptions{ | ||
| Interval: defaultInterval, | ||
| RunID: "1234", | ||
| Compact: true, | ||
| }, | ||
| }, | ||
|
Comment on lines
+60
to
+68
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We also need a test case in I think it's okay to just have a single test case that covers all cases. I know adding such tests is a bit annoying. 😄 So, let me know if I can help with that. 🙏
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @babakks: Regarding tests, I looked into it. |
||
| } | ||
|
|
||
| for _, tt := range tests { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: This can be pulled up to appear after the simple
gh run watchexample.