Closed
Conversation
Co-Authored-By: Nate Smith <[email protected]>
Co-Authored-By: Nate Smith <[email protected]>
Co-Authored-By: Nate Smith <[email protected]>
Co-Authored-By: Nate Smith <[email protected]>
Co-Authored-By: Nate Smith <[email protected]>
Co-Authored-By: Nate Smith <[email protected]>
Co-Authored-By: Nate Smith <[email protected]>
Co-Authored-By: Nate Smith <[email protected]>
Our code had an unspoken assumption that only one apiClient is created during the course of a command. Violating this assumption is fine in almost all cases, but not when we need to do a re-auth to add a new oauth scope to a user's token. There is likely a more elegant solution to the problem but until then this changes determineBaseRepo to use an existing apiClient.
This was an accidental casualty of refactoring in 3aaa231
Avoids the error when `localhost` was resolved to something else other
than `127.0.0.1`:
listen tcp 192.168.1.*:0: bind: can't assign requested address
Update release doc content
This is available now that we've bumped githubv4
removing extra line
Done Co-authored-by: Youssef Victor <[email protected]>
…view-pr-command 📚 docs(typo): fix typo in gh pr review command
Include 'go' instruction
Upgrade to Cobra 1.0
Fix referring to loopback interface in OAuth flow
Fix showing "Authentication complete" notice after OAuth dance
Bump project dependencies
Contributor
|
@billygriffin I think we will have to make a separate repo, just for people to test out |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay gh pr checkout 99085