Conversation
Most API errors are present in the response body itself, which will be sent to stdout normally, but if stdout is redirected somewhere (as it's common with scripts), failed HTTP requests will likely sabotage the rest of the script, but no useful info will be shown on stderr. This makes it so all REST and GraphQL errors are always shown on stderr. Additionally, this makes sure that the command exits with a nonzero status on any GraphQL errors.
Print HTTP errors on stderr in `api` command
probablycorey
approved these changes
Jun 10, 2020
Contributor
probablycorey
left a comment
There was a problem hiding this comment.
This makes the output so much easier to parse and use. Looks great!
vilmibm
approved these changes
Jun 10, 2020
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
My instinct is to be nervous about a custom json parser + raw ansi codes but the code is intelligible and it works 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
This should make it easier on the eyes when playing around with GitHub API. When the output is piped to a script, the data returned from the server is as before (unprocessed).
Ref. #332