Merged
Conversation
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an AGENTS.md document intended to guide agentic development and provide a concise “how this repo works” reference for contributors/automation in the GitHub CLI codebase.
Changes:
- Introduces
AGENTS.mdwith build/test/lint commands and repository architecture notes - Documents common command patterns (Options + Factory), JSON output conventions, and testing practices
- Captures guidance on error handling, feature detection, and API usage patterns
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BagToad
reviewed
Mar 24, 2026
| ### Generated Mocks | ||
|
|
||
| Interfaces use `moq`: `//go:generate moq -rm -out prompter_mock.go . Prompter`. Run `go generate ./...` after interface changes. | ||
|
|
Member
There was a problem hiding this comment.
Could we add another heading about using table test patterns? 🙏
BagToad
approved these changes
Mar 24, 2026
Member
BagToad
left a comment
There was a problem hiding this comment.
LGTM - just a small request in a comment
babakks
approved these changes
Mar 24, 2026
Member
babakks
left a comment
There was a problem hiding this comment.
LGTM. I'd also appreciate if agents are instructed to avoid unnecessary comments, and also add godocs to exported declrations.
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds foundational
AGENTS.mdto guide agentic development in this repository. I asked GPT 5.4, Opus 4.6, and Sonnet 4.6 to review it for token optimization. I expect we will iterate on this in every PR as we discover necessary prompting changes, but felt like we should land something to begin with.