Merged
Conversation
mislav
approved these changes
Dec 5, 2019
Contributor
mislav
left a comment
There was a problem hiding this comment.
Great find!
I don't feel it's the way to go right now that different queries share the same fragment for PR, because that will likely result in overfetching. For instance, this query does not need information about Reviews and Checks, but some other queries do.
I'd like us to explore a more declarative GraphQL query interface that would allow the caller to specify the fields that it wants per-invocation. That way, each caller specifies exactly the fields that it needs to consume.
mislav
pushed a commit
that referenced
this pull request
Sep 28, 2021
fork go-ghcs-crypto repo into internal module
cchristous
pushed a commit
to cchristous/cli
that referenced
this pull request
Feb 28, 2026
Handle SSH Server/Client race conditions; Verbose message if SSH returns permission denied
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #137. The problem was we weren't returning the URL in graphql, the computer tries to open an empty string, and that triggers the Finder to open.
I considered making some PR graphql fragments that all the PR queries can use, but wanted to see if others thought it was necessary before I refactored all the PR queries.