Conversation
mislav
reviewed
Nov 30, 2020
cmd/gh/main.go
Outdated
| fmt.Fprintln(stderr) | ||
| fmt.Fprintln(stderr, "To authenticate, please run `gh auth login`.") | ||
| fmt.Fprintln(stderr, "You can also set the one of the auth token environment variables, if preferred.") | ||
| fmt.Fprintln(stderr, "You can also set one of the auth token environment variables, if preferred.") |
Contributor
There was a problem hiding this comment.
I've missed this in my review of #2388, but I think that this line isn't very useful anymore. It used to give a more specific advice to set GITHUB_TOKEN.
@samcoe: do you agree that we should maybe take the whole line out? If users want to learn about our environment variable support, they can read so in our docs.
Contributor
Author
There was a problem hiding this comment.
Pushed a fixup commit that deletes the line. Please confirm, then I'll squash the commits.
Contributor
There was a problem hiding this comment.
Yup, I agree, this line is not very useful anymore. I am on board with removing it completely.
samcoe
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor typo :)