Closed
Conversation
handling for Boolean return types in from-java similar to clojure.core.bean
|
Any updates on merging this? Thanks for the PR! |
Member
|
This project does not accept PR contributions (see https://github.com/clojure/java.data/blob/master/CONTRIBUTING.md). Issues and patches should be filed on the JIRA system at https://dev.clojure.org/jira/browse/JDATA. Just from a glance, it's usually a bad idea to call directly into Reflector, which is considered an implementation class inside Clojure, subject to change. I think you could get the same effect with code similar to prepRet that you write directly. I'm going to close this PR here, but feel free to file it as an issue with the equivalent patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem are boolean attributes because they are converted into Booleans when Reflection is used to call the getter but not to Boolean.TRUE and Boolean.FALSE. Therefore, the return value needs to be converted using clojure.lang.Reflector/prepRet.