Skip to content

chore: Allow grpc-tools build scripts in pnpm config#143

Merged
kodiakhq[bot] merged 2 commits intomainfrom
claude/cool-wiles
Apr 1, 2026
Merged

chore: Allow grpc-tools build scripts in pnpm config#143
kodiakhq[bot] merged 2 commits intomainfrom
claude/cool-wiles

Conversation

@erezrokah
Copy link
Copy Markdown
Member

@erezrokah erezrokah commented Apr 1, 2026

Summary

  • pnpm blocks build scripts by default — grpc-tools needs its install script to download the native protoc binary, causing ENOENT in the regen workflow

Test plan

  • Trigger regen workflow manually via workflow_dispatch and verify it passes

Copilot AI review requested due to automatic review settings April 1, 2026 09:18
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the regen GitHub Actions workflow to use Node.js 22 (LTS) instead of Node.js 24 to maintain compatibility with grpc-tools prebuilt protoc binaries during code generation.

Changes:

  • Downgrade Node.js version in the regen workflow from 24 to 22.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@erezrokah erezrokah force-pushed the claude/cool-wiles branch from a454326 to aa867dc Compare April 1, 2026 09:21
@erezrokah erezrokah changed the title fix: Use Node.js 22 in regen workflow for grpc-tools compatibility fix: Allow grpc-tools build scripts in pnpm config Apr 1, 2026
@erezrokah erezrokah changed the title fix: Allow grpc-tools build scripts in pnpm config chore: Allow grpc-tools build scripts in pnpm config Apr 1, 2026
@erezrokah erezrokah added the automerge Add to automerge PRs once requirements are met label Apr 1, 2026
@kodiakhq kodiakhq bot merged commit a0862d4 into main Apr 1, 2026
5 checks passed
@kodiakhq kodiakhq bot deleted the claude/cool-wiles branch April 1, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Add to automerge PRs once requirements are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants