Skip to content

[Spec 0056] Relocate consult review types to consult-types/#108

Merged
waleedkadous merged 5 commits intomainfrom
builder/0056-consult-types-refactor
Dec 15, 2025
Merged

[Spec 0056] Relocate consult review types to consult-types/#108
waleedkadous merged 5 commits intomainfrom
builder/0056-consult-types-refactor

Conversation

@waleedkadous
Copy link
Copy Markdown
Contributor

Summary

Relocates consult review types from codev/roles/review-types/ to codev/consult-types/ to provide a cleaner, more intuitive location for review type prompts.

Key changes:

  • New consult-types/ directory in skeleton and local project
  • Backward compatibility fallback with deprecation warning for old roles/review-types/ location
  • codev doctor checks for proper migration
  • Documentation updates with migration instructions
  • 8 new tests covering the migration functionality

Test plan

  • Run full test suite: 248 tests passing
  • Verify consult --type spec-review works with new location
  • Verify fallback to deprecated location shows warning
  • Verify codev doctor warns about missing consult-types/
  • Verify codev doctor warns about deprecated roles/review-types/
  • External review by Gemini and Codex (feedback addressed)

Migration Note (for users upgrading to v1.4.0+)

mkdir -p codev/consult-types
mv codev/roles/review-types/* codev/consult-types/
rm -r codev/roles/review-types

Builders now automatically get a symlink to the project's .env file,
giving them access to environment variables needed for running tests
and local development.
0056: Consult Types Refactor - Move review types from roles/review-types/ to consult-types/
0057: Dashboard Tab Overhaul - Rename Projects to Dashboard, add two-column layout
- Update command docs with consult-types/ location and migration note
- Add test for deprecation warning functionality
- Fix loadReviewTypePrompt to properly distinguish local vs skeleton files
- Skip CLI existence check in dry-run mode for testability
@waleedkadous
Copy link
Copy Markdown
Contributor Author

Architect Integration Review (3-Way)

Verdict: REQUEST_CHANGES

Review Summary

Model Verdict Key Points
Gemini APPROVE Solid refactor with proper backward compatibility
Codex REQUEST_CHANGES Embedded skeleton not synced

Critical Issue

The embedded skeleton (packages/codev/skeleton/) was not updated. Only codev-skeleton/ received the changes.

Problem: Published npm installs use packages/codev/skeleton/ (copied at build time). Currently that directory still has roles/review-types/ and lacks consult-types/. This means:

  • Published CLI won't find prompts in new location
  • codev doctor will warn on every fresh install
  • New projects won't get the new structure

Fix Required:

cd packages/codev
npm run copy-skeleton
git add skeleton/
git commit --amend

Minor Notes (from Gemini)

  1. Consider updating projectlist.md status to implemented since PR is ready
  2. PR includes 0057 specs/plans which are unrelated to this PR (acceptable but noted)

🏗️ Architect integration review

@waleedkadous
Copy link
Copy Markdown
Contributor Author

Update: Approved

Builder correctly clarified the build workflow:

  • codev-skeleton/ is the source (tracked in git) ✓
  • packages/codev/skeleton/ is generated at build time via npm run copy-skeleton
  • The PR correctly updates codev-skeleton/

Codex's concern was based on checking the local build artifact state, not the committed source.

Verdict: APPROVE

Builder can merge when ready.


🏗️ Architect

@waleedkadous waleedkadous merged commit a3e6c38 into main Dec 15, 2025
2 checks passed
waleedkadous added a commit that referenced this pull request Dec 15, 2025
- Project 0056 (consult-types refactor): PR #108 merged
- Project 0057 (dashboard tab overhaul): PR #107 merged
@waleedkadous waleedkadous deleted the builder/0056-consult-types-refactor branch January 8, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant