Skip to content

[Bugfix #454] Fix dashboard progress for ASPIR builders#455

Merged
waleedkadous merged 1 commit intomainfrom
builder/bugfix-454-dashboard-elapsed-time-shows-a
Feb 20, 2026
Merged

[Bugfix #454] Fix dashboard progress for ASPIR builders#455
waleedkadous merged 1 commit intomainfrom
builder/bugfix-454-dashboard-elapsed-time-shows-a

Conversation

@waleedkadous
Copy link
Copy Markdown
Contributor

Summary

Fixes #454

Root Cause

calculateProgress() in overview.ts only used the nuanced calculateSpirProgress() for spir and spider protocols, but not aspir. ASPIR shares the same phase structure (specify → plan → implement → review) and gates, so it should use the same calculator with plan-phase tracking.

Without this fix, ASPIR builders fall through to calculateEvenProgress() which gives flat percentage splits (20%/40%/60%/80%) without plan-phase granularity in the implement phase.

Note: The started_at field for elapsed time was already fixed in Bugfix #388. It is correctly set in createInitialState() and parsed by parseStatusYaml().

Fix

Added 'aspir' to the protocol check in calculateProgress() so ASPIR uses calculateSpirProgress().

Test Plan

  • Added 4 regression tests for ASPIR progress (basic phases, plan-phase tracking, gate-requested review)
  • All 1801 existing tests pass
  • Build succeeds

@waleedkadous waleedkadous merged commit a1f314c into main Feb 20, 2026
6 checks passed
@waleedkadous waleedkadous deleted the builder/bugfix-454-dashboard-elapsed-time-shows-a branch February 20, 2026 08:49
waleedkadous added a commit that referenced this pull request Feb 20, 2026
Includes:
- #447: Dashboard hostname display
- #448: Spawn improvements (no-spec + GitHub naming)
- #449: codev update --agent
- #452: Reconnect status dot + give-up fix
- #453: af send composing state
- #455: ASPIR progress calculator fix
- CI cron false alert fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard: Elapsed time shows '-' and progress shows 0% for builders

1 participant