Conversation
* fix(core): add custom liftItem to fix unnesting blocks with siblings (BLO-1017) ProseMirror's upstream liftListItem doesn't work with BlockNote's strict blockContainer schema (blockContent blockGroup?), producing RangeError when unnesting blocks that have siblings after them. This adds a minimal adaptation of liftToOuterList (mirroring the existing sinkItem adaptation) that correctly handles merging siblings into existing child blockGroups. Fixes BLO-835, BLO-899, BLO-953, BLO-844, BLO-847. * chore: address review feedback (const, unused import) * test: add test case for nesting block into sibling with existing children * chore: fix lint
…#2629) * fix(core): add missing selectionAtBlockStart guard in backspace columnList handler The "move to end of prev columnList" backspace handler was missing a check for whether the cursor is at the start of the block. This caused mid-text backspace next to a columnList to move the entire block into the column instead of deleting a character. * fix(core): add missing selectionAtBlockEnd guard in delete columnList handler Same bug as the backspace handler — the "move first block from next columnList" delete handler was missing a selectionAtBlockEnd check, causing mid-text delete next to a columnList to incorrectly move blocks. Also adds 3 delete tests mirroring the backspace tests, and marks the mid-text tests with TODOs for vitest browser mode migration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )