Amazon 1, Step1&Step2 - 마크업 구현#26
Merged
crongro merged 13 commits intocode-squad:pdvonzoofrom Jan 18, 2019
Merged
Conversation
crongro
approved these changes
Jan 18, 2019
Contributor
crongro
left a comment
There was a problem hiding this comment.
file별로 그룹정의가 너무 잘되어 있어서 좋습니다.
요즘은 결국 모듈단위로 css를 개발하게 되어서 이런게 필요하죠.
리팩토링은 더 하지마시고~ 방법은 아실테니..
js개발로 이제 들어가보세요.
| @@ -0,0 +1,42 @@ | |||
| // COLOR | |||
Contributor
There was a problem hiding this comment.
파일을 잘 분리하고, 네이밍도 잘 설계하셨음. 👍
| } | ||
| @font-face { | ||
| font-family: AmazonEmber; | ||
| src: url(../static/font/AmazonEmber_700.woff2) format('woff2'); |
Contributor
There was a problem hiding this comment.
요즘 웹폰트 성능개선 글들이 좀 있던데, 기회도면 참고로 알아두셔도 좋을 듯.
| font-size: 1.6rem; | ||
| &-checked{ | ||
| vertical-align: middle; | ||
| &::after{ |
Contributor
There was a problem hiding this comment.
너무 depth가 깊지 않게 않게만 하시면 될 듯.
Author
There was a problem hiding this comment.
넵 코멘트 감사합니다. 이 부분 유의해서 코드 작성하도록 하겠습니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
감사합니다.