Merged
Conversation
crongro
requested changes
Apr 8, 2019
Contributor
crongro
left a comment
There was a problem hiding this comment.
잘하셨어요.
리뷰드린 내용 참고해서 다음스텝하기 전에 수정해두세요.
승인/머지합니다
| } | ||
|
|
||
| let checkPramNum = function(...args) { | ||
| for (let val of args) { |
Contributor
There was a problem hiding this comment.
오! 잘 했어요.
rest parameter잘썼음.
for-of에 대해서 좀더 알아보세요.
| } | ||
|
|
||
| let getSquareArea = function(width, height) { | ||
| checkIsNum(arguments); |
Contributor
There was a problem hiding this comment.
여기에서는 check함수 두 개보다는 한개가 나을 듯
참고 :퍼사드패턴!
crongro
approved these changes
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YM & TUNA
다각형의 넓이 구하기 함수 구현