Merged
Conversation
Contributor
|
@mukeunzi |
crongro
approved these changes
Apr 9, 2019
Contributor
crongro
left a comment
There was a problem hiding this comment.
충돌해결 잘 했군요.
잘하셨어요. 머지합니다.
| for (let i=0; i<arguments.length; i++){ | ||
| if(typeof arguments[i] === "undefined"){ | ||
| throw Error("모든 인자를 입력하세요."); | ||
| function checkParamType(rest){ |
Contributor
There was a problem hiding this comment.
참고,
보통 rest라는 이름을 잘 안쓰긴해요.
parms 나 args 가 조금더 나아보이네요.
| } | ||
| } | ||
|
|
||
| function checkParameter(...rest){ |
Contributor
There was a problem hiding this comment.
잘하셨어요~!
중요한 로직이 아닌 것들은 이렇게 추상화시키면 분리하면 좋아요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facade pattern complete.