step2-2 YM & TUNA#78
Merged
honux77 merged 4 commits intocode-squad:ymink16from Apr 12, 2019
ymink16:step2-2
Merged
Conversation
crongro
requested changes
Apr 9, 2019
Contributor
crongro
left a comment
There was a problem hiding this comment.
수고하셨어요.
리뷰남겨드린 것만 보완하면 좋겠습니다.
areaCalculator.js
Outdated
| console.log(funcArr); | ||
| console.log(areaArr); | ||
|
|
||
| let result1 = "계산수행순서 : "; |
Contributor
There was a problem hiding this comment.
전역공간에 코드를 그대로 두지 않는 게 좋습니다.(이유는 차차 느껴보실 수 있을거에요)
여기 아래 부분도 함수안으로 이동~
Author
There was a problem hiding this comment.
제가 실수로 printExecutionSequence()함수를 사용하지 않고 이 내용들을 전역공간 밖에 두어서 이렇게 된거 같습니다. 수정했습니다~
cal.js
Outdated
| return Math.PI * r * r; | ||
| } | ||
|
|
||
| let getSquareArea = function(width, height) { |
Contributor
There was a problem hiding this comment.
arrow function도 있으니 참고하세요.
함수표현식에서 const가 좀더 나을 거 같은데, 왜 그런지 두 개의 차이를 알아보고, 고민해보세요.
cal.js
Outdated
| @@ -0,0 +1,51 @@ | |||
| let getCircleArea = function(r) { | |||
|
👍 머지합니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YM & TUNA
다각형의 넓이 - 함수구현