Skip to content

코드리뷰에 따라 코드 수정 #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crongro merged 1 commit into from
Apr 9, 2019
Merged

코드리뷰에 따라 코드 수정 #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions STEP2_1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
const {PI} = Math
const {pow} = Math

function checkType(arr) {
for (let i = 0; i < arr.length; i++) {
Expand All @@ -18,7 +19,7 @@ function circleArea(r) {
checkArgumentCount(arguments, 1);
checkType(arguments);

return PI * Math.pow(r, 2)
return PI * pow(r, 2)
}

function squareArea(width, height) {
Expand All @@ -39,7 +40,7 @@ function cylinderArea(r, h) {
checkArgumentCount(arguments, 2);
checkType(arguments);

return (2 * PI * Math.pow(r, 2)) + 2 * PI * r * h
return (2 * circleArea(r)) + 2 * PI * r * h
}

console.log(circleArea(3));
Expand Down