Merged
Conversation
1. Math.pow를 중복해서 호출 사용하던 것을 const{pow} = Math 로 비구조화할당하여 사용하는 것으로 수정하였습니다.
2. 원기둥을 구하는 함수 cylinderArea()에서 원의 넓이를 구하는데 circleArea() 함수를 재사용하는 것으로 수정하였습니다.
1.getArea()함수 구현 2.printExecutionSequence() 함수 구현 3.printExecutionSequence() 에서 함수의 결과까지 같이 출력하도록 수정
honux77
reviewed
Apr 12, 2019
| let getArea = (func_name, ...args) => { | ||
| switch (func_name){ | ||
| case 'circle': | ||
| result = utils.polygon.circle(...args); |
honux77
approved these changes
Apr 12, 2019
honux77
left a comment
There was a problem hiding this comment.
log에 문자열을 사용했는데, 배열을 이용해서 스택처럼 쌓으면 좋을 것 같아요.
그리고 로그를 기록하는 함수도 별도로 만들면 좋겠네요.
다음 PR에 반영해 주세요. 일단 머지합니다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Michelle & 수리 JS STEP2-2 구현