Merged
Conversation
honux77
reviewed
Apr 12, 2019
| @@ -1,42 +1,65 @@ | |||
| const PIE = Math.PI; | |||
honux77
reviewed
Apr 12, 2019
| let areaSum = 0; | ||
|
|
||
| module.exports.circle = function(r = -1){ | ||
| function circle(r = -1){ |
There was a problem hiding this comment.
그냥 circle보다는 areaCircle 같이 조금 더 명확한 이름이 좋습니다.
circle이라고 하면 코드의 내용까지 읽어야 어떤 함수인지를 알 수 있죠.
There was a problem hiding this comment.
다시 읽어보니 모듈의 이름이 area라서 circle도 괜찮을 것 같아요 😉
honux77
reviewed
Apr 12, 2019
| checkParameter(r); | ||
|
|
||
| if(r > 0){ | ||
| areaSum += Math.pow(r, 2) * PIE; |
honux77
reviewed
Apr 16, 2019
| @@ -1,8 +1,10 @@ | |||
| const PIE = Math.PI; | |||
| let areaSum = 0; | |||
| let stackList = []; | |||
|
코멘트 내용도 잘 반영해 주세요. 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mukeunzi & circus
step 2-2 다각형의 넓이 - 함수구현